-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new InvocationBuilderListener SPI #4313
new InvocationBuilderListener SPI #4313
Conversation
This new SPI interface allows for
|
ec4235d
to
16de364
Compare
@pdudits The |
16de364
to
1a1b9d7
Compare
I'll have a detailed look tomorrow, at first sight it looks good. One usually uses RestClientBuilder to build client for many invocations (in real applications, contrary to tests), so I think the relation of lifecycles are but different |
Signed-off-by: Jan Supol <[email protected]>
1a1b9d7
to
d29f416
Compare
I tested this API with the same four usecases as in #4301, code is in this branch. All of these usecases are satisfied by this, so I'm quite happy. |
core-client/src/main/java/org/glassfish/jersey/client/InvocationBuilderListenerStage.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Supol <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maybe consider possibility to get and modify URL to be called and access to configuration
…sible in the listener Signed-off-by: Jan Supol <[email protected]>
Signed-off-by: Jan Supol <[email protected]>
@tomas-langer I have added getters to the headers, configuration, and URI. |
Signed-off-by: Jan Supol [email protected]