-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assure that exception in async interceptor doesn't prevent completion #4292
Merged
jansupol
merged 1 commit into
eclipse-ee4j:master
from
pdudits:prevent-async-interceptor-throw
Oct 17, 2019
Merged
Assure that exception in async interceptor doesn't prevent completion #4292
jansupol
merged 1 commit into
eclipse-ee4j:master
from
pdudits:prevent-async-interceptor-throw
Oct 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Dudits <[email protected]>
Verdent
approved these changes
Oct 16, 2019
jansupol
approved these changes
Oct 17, 2019
This was referenced Jun 26, 2021
This was referenced Aug 5, 2021
This was referenced Aug 30, 2021
1 task
This was referenced Oct 4, 2021
This was referenced Oct 18, 2021
This was referenced Oct 21, 2021
Merged
Merged
This was referenced Oct 21, 2021
Closed
Closed
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally run Jersey REST Client against TCK version 1.1, which isn't binary comatible.
AsyncMethodTest
hung with it, becauseAsyncInvocationInterceptor
didn't yet have methodremoveContext
, and therefore this invocationjersey/ext/microprofile/mp-rest-client/src/main/java/org/glassfish/jersey/microprofile/restclient/MethodModel.java
Line 267 in 959b4e7
was throwing
AbstractMethodError
. This again happened inexceptionally
callback, causing resultingCompletableFuture
to never complete.The change will propagate any AsyncInvocationInterceptor failure to completion result.