-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4208 - Fails to inject SecurityContext into Helloworld-CDI2-SE example #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pa314159
changed the title
Issues/4208
Fails to inject SecurityContext into Helloworld-CDI2-SE example
Aug 28, 2019
pa314159
force-pushed
the
issues/4208
branch
2 times, most recently
from
August 28, 2019 12:07
c699bb2
to
fbd0bfb
Compare
Please update copyright year in the next push |
@jansupol, rebase or new commit? |
jansupol
reviewed
Aug 28, 2019
inject/cdi2-se/src/main/java/org/glassfish/jersey/inject/cdi/se/bean/SupplierBeanBridge.java
Show resolved
Hide resolved
rebase is fine, small PR |
Signed-off-by: pappy <[email protected]>
pa314159
changed the title
Fails to inject SecurityContext into Helloworld-CDI2-SE example
Issue 4208 - Fails to inject SecurityContext into Helloworld-CDI2-SE example
Aug 28, 2019
pa314159
force-pushed
the
issues/4208
branch
3 times, most recently
from
August 28, 2019 17:35
569ec12
to
3a9430b
Compare
The method JersetBean.getBeanClass is used to compute the bean identifier. The default id for a JerseyBean<T> is "java.lang.Object#jersey", causing collisions of bridge instances. In particular, for HelloWorldResourceTest, Weld's MapBeanStore returned a SupplierInstanceBeanBridge instead of the expected SupplierBeanBridge, because both shared the same bean identifier. Signed-off-by: pappy <[email protected]>
senivam
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work :)
jansupol
approved these changes
Aug 29, 2019
This was referenced Jun 26, 2021
1 task
This was referenced Oct 21, 2021
Closed
Closed
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.