-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 9.4.22 QueuedThreadPool compatibility #4302
Comments
Bumps `version.jetty` from 9.4.21.v20190926 to 9.4.22.v20191022. Updates `jetty-servlets` from 9.4.21.v20190926 to 9.4.22.v20191022 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.21.v20190926...jetty-9.4.22.v20191022) Updates `jetty-server` from 9.4.21.v20190926 to 9.4.22.v20191022 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.21.v20190926...jetty-9.4.22.v20191022) Updates `websocket-api` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-common` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-client` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-server` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-servlet` from 9.4.21.v20190926 to 9.4.22.v20191022 Update JettyWebTestContainerFactory to work around jetty breaking change: eclipse-ee4j/jersey#4302 Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps `version.jetty` from 9.4.21.v20190926 to 9.4.22.v20191022. Updates `jetty-servlets` from 9.4.21.v20190926 to 9.4.22.v20191022 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.21.v20190926...jetty-9.4.22.v20191022) Updates `jetty-server` from 9.4.21.v20190926 to 9.4.22.v20191022 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.21.v20190926...jetty-9.4.22.v20191022) Updates `websocket-api` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-common` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-client` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-server` from 9.4.21.v20190926 to 9.4.22.v20191022 Updates `websocket-servlet` from 9.4.21.v20190926 to 9.4.22.v20191022 Update JettyWebTestContainerFactory to work around jetty breaking change: eclipse-ee4j/jersey#4302 Signed-off-by: dependabot-preview[bot] <[email protected]>
You don't need to customize the QueuedThreadPool any more. |
I agree with making the method public. We probably should not rely on the new We may change it later. |
@jansupol This incompatibility causes a bug for anyone using the spring-boot-dependencies bom as a baseline for version management (see spring-projects/spring-boot#19769). I asked about options on the jetty project (see jetty/jetty.project#4121), but in parallel I'd like to ask whether there is a possibility of a special 2.29.x release compatible with the new jetty API. |
Per, jetty/jetty.project#4121 QueuedThreadPool implements ThreadFactory, which makes the newThread method public instead of protected. The JettyConnectorThreadPool class in JettyHttpContainerFactory has the newThread method marked as protected, and causes an IllegalAccessError when used at runtime (it also fails to compile if compiled against jetty 9.4.22):
The text was updated successfully, but these errors were encountered: