jaxb-tck/issues/78 switch to https://www.w3.org/2005/05/xmlmime #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarlow
changed the title
bstansberry
reviewed
Sep 13, 2022
| @@ -23,7 +23,7 @@ private WellKnownNamespace() {} // no instanciation please | |||
|
|
|||
| public static final String SWA_URI = "http://ws-i.org/profiles/basic/1.1/xsd"; | |||
|
|
|||
| public static final String XML_MIME_URI = "http://www.w3.org/2005/05/xmlmime"; | |||
| public static final String XML_MIME_URI = "https://www.w3.org/2005/05/xmlmime"; | |||
There was a problem hiding this comment.
I believe this shouldn't change. It's the namespace name, which is just a string. And that name is part of the spec.
bstansberry
reviewed
Sep 13, 2022
| @@ -622,7 +622,7 @@ private void writeTo(Result result, Map<Namespace,String> systemIds) throws IOEx | |||
| schema._import().namespace(WellKnownNamespace.SWA_URI).schemaLocation("http://ws-i.org/profiles/basic/1.1/swaref.xsd"); | |||
| } | |||
| if(useMimeNs) { | |||
| schema._import().namespace(WellKnownNamespace.XML_MIME_URI).schemaLocation("http://www.w3.org/2005/05/xmlmime"); | |||
| schema._import().namespace(WellKnownNamespace.XML_MIME_URI).schemaLocation("https://www.w3.org/2005/05/xmlmime"); | |||
There was a problem hiding this comment.
This schema location otoh is a url where the schema is found, so there changing https makes sense to me.
There was a problem hiding this comment.
Thanks, I'll try to test again with just this line changed!
|
Results so far are looking better: Will let it run to completion and report back on results. |
Signed-off-by: Scott Marlow <[email protected]>
scottmarlow
force-pushed
the
https_xmlmime
branch
from
ef2881a to
ac7a594
Compare
|
Looks good now, XML Binding 4.0 TCK Test results from WildFly with this change: |
@scottmarlow It's good to know that these uris are actually defined in jaxb-ri instead of jaxb-tck source. How did you find this should be fixed in jaxb-ri ? |
|
4.0.1 is in staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Marlow [email protected]
This change doesn't seem to help directly with jakartaee/jaxb-tck#78 but will create a draft pr in case we want to merge it anyway (we can switch to ready for review). I immediately saw the following failures with this change, so it didn't seem to help: