Issue #2215 Fix invalid Origin header sent by client for non-SSL WebSocket connections #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgdrake
force-pushed
the
bugfix/issue_2215
branch
from
661418d to
6399a95
Compare
carryel
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Changes look good.
There are two things that would be good to reflect.
- It seems that the license header needs to be revised and added. It seems that you can reflect the year by referencing other files and pasting them.
- I wonder if it is possible to PR to the main branch rather than the master branch.
cgdrake
force-pushed
the
bugfix/issue_2215
branch
from
6399a95 to
2aee7c0
Compare
…non-SSL WebSocket connections
cgdrake
force-pushed
the
bugfix/issue_2215
branch
from
2aee7c0 to
a0d6f8a
Compare
|
@carryel I have corrected the PR to target the main branch and also updated the copyrights. |
carryel
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for incorrect scheme detection within Handshake constructor. See issue #2215.