-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented #2153 - Upgraded to Servlet 6 #2156
Conversation
Signed-off-by: David Matějček <[email protected]>
Local build passed including tests |
Could the JDK used in https://ci.eclipse.org/grizzly/job/Grizzly-master_nightly/ be updated, please? |
I don't have rights to do that, seems at least switching from JDK8 to JDK11 would be nice ... @arjantijms ? |
I'm on it, thanks! |
Update done! |
thanks! and of course -
|
private boolean httpOnly = true; | ||
private boolean secure; | ||
private static final int DEFAULT_MAX_AGE = -1; | ||
private static final boolean DEFAULT_HTTP_ONLY = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmatej could you tell me the reason for changing this default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, but I don't know after 3 months, perhaps I should make a comment in the commit. It seems to me as a mistake now.
Signed-off-by: David Matějček [email protected]