introduce FileChunk interface to transfer file chunks #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileTransfer class is designed to utilize OS zero-copy capability to write a file into a socket. However it opens and closes the file. This might be not optimal if we need to send a ching of a file. The introduced FileChunk interface aims to add more flexibility. Signed-off-by: Tigran Mkrtchyan <[email protected]>
MattGill98
approved these changes
May 19, 2022
|
This PR is still missing in master branch, it was merged just to 3.0.1. |
|
@dmatej Shall I make a RP against master? |
|
See #2169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileTransfer class is designed to utilize OS zero-copy capability to
write a file into a socket. However it opens and closes the file. This
might be not optimal if we need to send a ching of a file.
The introduced FileChunk interface aims to add more flexibility.
Signed-off-by: Tigran Mkrtchyan [email protected]