Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-info.class major version: 53 #83

Open
jbescos opened this issue Feb 8, 2023 · 4 comments
Open

package-info.class major version: 53 #83

jbescos opened this issue Feb 8, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jbescos
Copy link
Member

jbescos commented Feb 8, 2023

package-info.class is supposed to have the major version 52

This is a known issue in other projects too:
jakartaee/mail-api#660
eclipse-ee4j/parsson#73

jbescos added a commit to jbescos/angus-mail that referenced this issue Feb 8, 2023
@aalmiray
Copy link

aalmiray commented Feb 8, 2023

It's not just package-info.class, there are others

$ jarviz bytecode show --gav org.eclipse.angus:angus-mail:2.0.1
Unversioned classes. Bytecode version: 52 total: 203
Unversioned classes. Bytecode version: 53 total: 12

These are the classes with bytecode version 53:

Unversioned classes. Bytecode version: 53 total: 12
org.eclipse.angus.mail.util.logging.package-info
org.eclipse.angus.mail.util.package-info
org.eclipse.angus.mail.imap.protocol.package-info
org.eclipse.angus.mail.imap.package-info
org.eclipse.angus.mail.iap.package-info
org.eclipse.angus.mail.handlers.package-info
org.eclipse.angus.mail.pop3.package-info
org.eclipse.angus.mail.smtp.package-info
org.eclipse.angus.mail.auth.package-info
org.eclipse.angus.mail.nativeimage.AngusMailFeature
org.eclipse.angus.mail.package-info
module-info

All of them should be inside /META-INFO/versions/9. Take note of org.eclipse.angus.mail.nativeimage.AngusMailFeature.

lukasj added a commit that referenced this issue Apr 26, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Co-authored-by: Lukas Jungmann <[email protected]>
@lukasj
Copy link
Member

lukasj commented May 3, 2023

fixed by #84

@lukasj lukasj closed this as completed May 3, 2023
@aalmiray
Copy link

aalmiray commented May 3, 2023

In a way it's fixed, yes. Then again classes compiled with bytecode 53 should be placed under META-INF/versions/9 while the rest of the codebase remains with bytecode 52. The JAR file should also be marked as a Multi Release JAR with a Multi-Release: true attribute in its manifest.

@lukasj
Copy link
Member

lukasj commented May 3, 2023

Ah, right missed that piece

@lukasj lukasj reopened this May 3, 2023
@jmehrens jmehrens added bug Something isn't working good first issue Good for newcomers labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants