Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sanitization of AZKV keys #15

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Improves the sanitization of Azure Keyvault secret names.

Why it does that

Make the AZKV more fault-tolerant, avoid avoidable exceptions.

Further notes

  • does not truncate the string to 127 characters, as that could potentially cause name collisions. In case of a length violation, the AZKV would report an error.

Linked Issue(s)

Closes #14

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jun 27, 2023
@paullatzelsperger paullatzelsperger self-assigned this Jun 27, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Test Results

  57 files  ±  0    57 suites  ±0   22m 16s ⏱️ - 6m 32s
550 tests +10  541 ✔️ +10  9 💤 ±0  0 ±0 
560 runs  +10  551 ✔️ +10  9 💤 ±0  0 ±0 

Results for commit 085bfdf. ± Comparison against base commit 4d7aff2.

This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.
org.eclipse.edc.connector.dataplane.azure.datafactory.AzureDataFactoryTransferManagerTest ‑ [5] [Queued, InProgress, 1767afb6-d4fc-49f0-9e5e-ef9832251e7b]
org.eclipse.edc.connector.dataplane.azure.datafactory.AzureDataFactoryTransferManagerTest ‑ [5] [Queued, InProgress, dd93b1c2-4161-4c29-bfd2-dfd07ffea569]
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [1] foo_bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [2] foo%bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [3] foo.bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [4] foo^bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [5] foo#bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [6] foo;bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [7] foo_&*_bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [8] foo__bar
org.eclipse.edc.vault.azure.AzureVaultTest ‑ [9] foo%%@#$bar
…

♻️ This comment has been updated with latest results.

@paullatzelsperger paullatzelsperger merged commit c5c1f3a into main Jun 29, 2023
@ndr-brt ndr-brt deleted the feature/14_improve_sanitization branch September 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve sanitization of KeyVault secrets
2 participants