Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix invalid command line in the README of transfer-00-prerequisites #149

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

iwasakims
Copy link
Contributor

What this PR changes/adds

fix the invalid command line of README of transfer-00-prerequisites.

Why it does that

extra | before -s causes error on copying from browser and pasting.

$ curl -H 'Content-Type: application/json' \
     -d @transfer/transfer-00-prerequisites/resources/dataplane/register-data-plane-provider.json \
     -X POST "http://localhost:19193/management/v2/dataplanes" | -s | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to localhost port 19193 after 0 ms: Connection refused
-s: command not found

Linked Issue(s)

Closes #148

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ndr-brt ndr-brt added the bug Something isn't working label Nov 13, 2023
@ndr-brt ndr-brt merged commit d4ea6ec into eclipse-edc:main Nov 13, 2023
5 of 6 checks passed
majadlymhmd pushed a commit to FraunhoferISST/edc-samples that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix invalid command line in the README of transfer-00-prerequisites
2 participants