Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter for the target branch #23

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

adds a branch parameter to the release workflow, so that it can be specified from which source branch the release is to be created.

Why it does that

Briefly state why the change was necessary.

Further notes

  • creating GitHub releases and posting to Discord is skipped if the source branch is not main. This is a first version, and support for GH releases could be added later.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jun 13, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/enable_publishing_with_branch branch from 5bf4443 to 366ca72 Compare June 13, 2024 11:41
@paullatzelsperger paullatzelsperger force-pushed the feat/enable_publishing_with_branch branch from 366ca72 to 13f4409 Compare June 13, 2024 11:43
@paullatzelsperger
Copy link
Member Author

will merge, as the failing build has to do with compile errors introduced by eclipse-edc/Connector#4237 and will be fixed with eclipse-edc/IdentityHub#370

@paullatzelsperger paullatzelsperger merged commit 3eb5473 into eclipse-edc:main Jun 13, 2024
1 of 2 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/enable_publishing_with_branch branch June 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants