feat: check if DID exists before creating a participant #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/check_if_did_exists
branch
from
ea4b225
to
87d4237
Compare
paullatzelsperger
force-pushed
the
feat/check_if_did_exists
branch
from
e2b0836
to
deb11ff
Compare
bscholtes1A
approved these changes
Aug 23, 2024
wolf4ood
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
defensively checks if another ParticipantContext already exists with the same DID when creating ParticipantContexts
Why it does that
defensive checks are better than relying on the database operation failing with a PK violation