Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement SQL variants for E2E tests #401

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jul 17, 2024

What this PR changes/adds

Adds SQL variants for E2E tests in api-tests module

Why it does that

test coverage. some errors only pop up when actual persistence is used.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #394

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Jul 17, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jul 17, 2024
@wolf4ood wolf4ood force-pushed the feat/394_sql_persistence_in_e2e_tests branch from 31eee98 to c8e5cbb Compare July 17, 2024 09:42
@wolf4ood wolf4ood marked this pull request as ready for review July 17, 2024 09:57
@wolf4ood wolf4ood merged commit f9ef30f into eclipse-edc:main Jul 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E tests for Postgres persistence
2 participants