fix: use type and credentialSubject properties in VerifiableCredential
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
approved these changes
Feb 20, 2024
bscholtes1A
force-pushed
the
fix/vc_type_credentialsubject_properties
branch
from
fe11e14
to
bbb8639
Compare
bscholtes1A
force-pushed
the
fix/vc_type_credentialsubject_properties
branch
from
bbb8639
to
a8fcf2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use class argument name and serialized name for the
typeandcredentialSubjectproperties of theVerifiableCredentialobject.Why it does that
This is required to have a consistent way to query for a VC independently on the type of VC store (in-mem store uses reflection while PostgreSQL store will work on the serialized json structure.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.