chore: some refactoring and cleanup #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
refactoring
paullatzelsperger
force-pushed
the
chore/minor_refactoring_and_cleanup
branch
from
6e89d0e
to
a6de2f5
Compare
wolf4ood
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR performs some refactoring and module restructuring:
AuthorizationService: signature change, now takes aSecurityContextinstead of aPrincipalto enable easy customization of the role-based access controlidentityhub-api-authmodule was split into anidentityhub-api-authenticationandidentityhub-api-authorizationmodule to allow for more modularityServicePrincipal.ROLE_ADMINManagementApiConfiguration: a new abstract base class was introduced in thespimodule to decouple the config module and the authentication moduleServicePrincipalandServicePrincipalResolverwere moved tospiWhy it does that
cleanup. also, in a subsequent PR documentation will follow, that will reference these changes. --> #254
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.