feat: use events to decouple services #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/232_use_events_to_decouple_services
branch
from
eb8451f
to
4b02a34
Compare
jimmarino
reviewed
Jan 30, 2024
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
...b-spi/src/main/java/org/eclipse/edc/identityhub/spi/events/diddocument/DidDocumentEvent.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/edc/identityhub/spi/events/participant/ParticipantContextDeleted.java
Show resolved
Hide resolved
...main/java/org/eclipse/edc/identityhub/spi/events/participant/ParticipantContextListener.java
Show resolved
Hide resolved
...main/java/org/eclipse/edc/identityhub/spi/events/participant/ParticipantContextListener.java
Show resolved
Hide resolved
wolf4ood
approved these changes
Jan 30, 2024
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jim Marino <[email protected]>
…/spi/events/diddocument/DidDocumentEvent.java Co-authored-by: Jim Marino <[email protected]>
jimmarino
approved these changes
Jan 30, 2024
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR introduces events, which are emitted by services, to decrease service coupling.
Specifically these services emit events:
participantContextServiceKeyPairServiceVerifiableCredentialServiceWhy it does that
Decrease service coupling
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #232
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.