feat: add Management API for KeyPairResources #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/235_add_keypairresource_managementapi
branch
2 times, most recently
from
254e897
to
8170aa2
Compare
paullatzelsperger
force-pushed
the
feat/235_add_keypairresource_managementapi
branch
3 times, most recently
from
a111de4
to
c44a3cb
Compare
paullatzelsperger
force-pushed
the
feat/235_add_keypairresource_managementapi
branch
from
c44a3cb
to
5d2f429
Compare
jimmarino
approved these changes
Jan 29, 2024
| void rotateKeyPair(String id, KeyDescriptor newKey, long duration, SecurityContext securityContext); | ||
|
|
||
| @Tag(name = "KeyPairResources Management API") | ||
| @Operation(description = "Revokes (=removes) a particular key pair, identified by their ID and create a new successor key.", |
There was a problem hiding this comment.
We should have the option of rotating and revoking a key without generating successor keys. This could be a non-default case
There was a problem hiding this comment.
yeah, I initially had it that way, but I couldn't figure out a use case where "phasing out" a key without a successor would be needed. Note that revoking does not require a successor, even now.
should I make the successor optional also when rotating?
There was a problem hiding this comment.
Yes, that would be good.
wolf4ood
approved these changes
Jan 29, 2024
paullatzelsperger
deleted the
feat/235_add_keypairresource_managementapi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a management API for
KeyPairResources, that allows to:Why it does that
managing key pairs
Further notes
SqlOperatorTranslatorand changes to thePresentatinQueryMessageandPresentationResponseMessageLinked Issue(s)
Closes #235
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.