feat: create KeyPairGenerator #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| algorithm = algorithm.toUpperCase(); | ||
| if (SUPPORTED_ALGORITHMS.contains(algorithm)) { | ||
| return switch (algorithm) { | ||
| case ALGORITHM_RSA -> generateRsa(Integer.parseInt(parameters.getOrDefault(RSA_PARAM_LENGTH, RSA_DEFAULT_LENGTH).toString())); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
...ons/common/security/src/main/java/org/eclipse/edc/identityhub/security/KeyPairGenerator.java
Dismissed
Show dismissed
Hide dismissed
...ons/common/security/src/main/java/org/eclipse/edc/identityhub/security/KeyPairGenerator.java
Dismissed
Show dismissed
Hide dismissed
wolf4ood
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds an implementation of a
KeyPairGeneratoras lib classWhy it does that
For various subsequent development steps we need to generate keys.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #221
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.