Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQL implementation of TargetNodeDirectory #241

Merged

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

SQL implementation of TargetNodeDirectory.

Why it does that

Persistent implementation of TargetNodeDirectory.

Linked Issue(s)

Closes #240

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@bscholtes1A bscholtes1A force-pushed the feat/240_sql_target_node_directory branch from ced8663 to 6e93654 Compare August 14, 2024 12:52
@bscholtes1A bscholtes1A added the persistence any feature that has something to do with Cosmos, Postgres, etc. label Aug 14, 2024
@bscholtes1A bscholtes1A force-pushed the feat/240_sql_target_node_directory branch from 6e93654 to 8636ad7 Compare August 14, 2024 12:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.25%. Comparing base (2d71ca0) to head (e20b1f1).
Report is 78 commits behind head on main.

Files Patch % Lines
.../edc/catalog/store/sql/SqlTargetNodeDirectory.java 89.74% 4 Missing ⚠️
...log/store/sql/SqlTargetNodeDirectoryExtension.java 88.88% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #241       +/-   ##
===========================================
+ Coverage   65.43%   76.25%   +10.81%     
===========================================
  Files          25       31        +6     
  Lines         434      657      +223     
  Branches       15       26       +11     
===========================================
+ Hits          284      501      +217     
- Misses        135      136        +1     
- Partials       15       20        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 16, 2024
@bscholtes1A bscholtes1A force-pushed the feat/240_sql_target_node_directory branch from 8636ad7 to 133c844 Compare August 19, 2024 07:37
@bscholtes1A bscholtes1A force-pushed the feat/240_sql_target_node_directory branch from 133c844 to e20b1f1 Compare August 19, 2024 07:49
@bscholtes1A bscholtes1A merged commit 5af5314 into eclipse-edc:main Aug 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request persistence any feature that has something to do with Cosmos, Postgres, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: SQL implementation of TargetNodeDirectory
4 participants