Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: publish openapi spec under the catalog-api group #235

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 5, 2024

What this PR changes/adds

Publishes the catalog openapi spec under the correct catalog-api context instead of management-api

Why it does that

documentation

Further notes

  • removed useless apiGroup.set calls from modules without api specs
  • added resources/openapi/*.version file, needed to publish the spec with the correct version

Linked Issue(s)

Closes #232
Closes #229

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Aug 5, 2024
@ndr-brt ndr-brt requested a review from wolf4ood August 5, 2024 07:56
Copy link

github-actions bot commented Aug 5, 2024

Test Results

20 files  ±0  20 suites  ±0   49s ⏱️ -1s
66 tests ±0  66 ✅ ±0  0 💤 ±0  0 ❌ ±0 
75 runs  ±0  75 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4553c36. ± Comparison against base commit 79dbdd4.

♻️ This comment has been updated with latest results.

@ndr-brt ndr-brt merged commit a8168be into main Aug 5, 2024
30 of 31 checks passed
@ndr-brt ndr-brt deleted the 232-fix-api-spec-context branch August 5, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api specs are published with wrong context Catalog API link does not work
2 participants