Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sql federated catalog cache #218

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jul 9, 2024

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #221

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.08911% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (2d71ca0) to head (5f7f878).
Report is 62 commits behind head on main.

Files Patch % Lines
...dc/catalog/store/sql/SqlFederatedCatalogCache.java 84.00% 8 Missing ⚠️
...g/store/sql/SqlFederatedCatalogCacheExtension.java 85.71% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   65.43%   73.50%   +8.07%     
==========================================
  Files          25       25              
  Lines         434      570     +136     
  Branches       15       25      +10     
==========================================
+ Hits          284      419     +135     
+ Misses        135      132       -3     
- Partials       15       19       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood self-assigned this Jul 9, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Jul 9, 2024
@wolf4ood wolf4ood force-pushed the feat/207_sql_catalog_cache branch from 7a9e0d7 to c777b8c Compare July 9, 2024 10:47
@wolf4ood wolf4ood marked this pull request as ready for review July 9, 2024 12:27
@wolf4ood wolf4ood merged commit 42b2607 into eclipse-edc:main Jul 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide SQL Migrations by default
3 participants