Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): adopt EDC test runtime model #198

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adopts the new test runtime model of upstream EDC

Why it does that

Avoid technical debt

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jun 11, 2024
Copy link

github-actions bot commented Jun 11, 2024

Test Results

57 tests  ±0   57 ✅ ±0   1m 4s ⏱️ -13s
14 suites ±0    0 💤 ±0 
14 files   ±0    0 ❌ ±0 

Results for commit 968bc3f. ± Comparison against base commit 6890773.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
org.eclipse.edc.catalog.api.query.FederatedCatalogApiControllerTest ‑ queryApi_whenQueryUnsuccessful(CacheQueryAdapterRegistry)
org.eclipse.edc.catalog.api.query.FederatedCatalogApiControllerTest ‑ queryApi_whenResultsReturned(FederatedCacheStore)
org.eclipse.edc.catalog.api.query.FederatedCatalogApiControllerTest ‑ queryApi_whenQueryUnsuccessful()
org.eclipse.edc.catalog.api.query.FederatedCatalogApiControllerTest ‑ queryApi_whenResultsReturned()

♻️ This comment has been updated with latest results.

@paullatzelsperger paullatzelsperger merged commit a58fa4b into main Jun 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants