Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update mat-card components #259

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

s-damith
Copy link
Contributor

What this PR changes/adds

Refactor Angular Material mat-card components to enhance UI and functionality on the introduction page.

Why it does that

Add padding to the internal elements of the card components and utilize standardized card component sub-elements.

localhost_4200_introduction(lap) (2)

Linked Issue(s)

Closes #258

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link
Contributor

@timdah timdah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also propose to set the font of mat-card (font-family: 'Open Sans') for a uniform typeface.

@s-damith s-damith requested a review from timdah December 18, 2024 17:26
Copy link
Contributor

@timdah timdah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the suggested font-family. The rest looks good to me.

@s-damith s-damith requested a review from timdah December 19, 2024 11:15
@juliapampus juliapampus added the enhancement New feature or request label Dec 19, 2024
@juliapampus juliapampus merged commit 94afc64 into eclipse-edc:main Dec 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card components misaligned on Introduction page
3 participants