Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Angular to 15 #115

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 17, 2023

What this PR changes/adds

Bump angular to version 15

Why it does that

dependency update

Further notes

  • had to adapt some css here and there, there could be other outdated stuff we're using, but the layout is pretty stable now.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Oct 17, 2023
@ndr-brt ndr-brt requested a review from janpmeyer October 17, 2023 10:29
@janpmeyer
Copy link
Contributor

I cant build the docker images with the docker compose command.

Error:

25.49 Error: bundle initial exceeded maximum budget. Budget 1.20 MB was not met by 142.00 kB with a total of 1.34 MB.

Solution should be to set up the budget Values in the angular.json file. Reference https://stackoverflow.com/questions/53995948/warning-in-budgets-maximum-exceeded-for-initial

Current ErrorBudget is set to 1.2 MB.

@ndr-brt ndr-brt force-pushed the bump-angular-15 branch 3 times, most recently from 3fc4037 to d1a3867 Compare October 19, 2023 07:34
@ndr-brt
Copy link
Member Author

ndr-brt commented Oct 19, 2023

@janpmeyer fixed, I also took the opportunity to add the first e2e with cypress, for the moment it just verifies that the test environment spins up correctly.

Copy link
Contributor

@janpmeyer janpmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Need to change the css files for this Links. Or do you like this Hyperlink underlines.

I have no much expertise for workflows, mabey you wanna get checked by sb. with more
knowledge in this topic.

@ndr-brt ndr-brt requested a review from janpmeyer October 19, 2023 09:18
@ndr-brt
Copy link
Member Author

ndr-brt commented Oct 19, 2023

@janpmeyer removed the underline from the menu

@ndr-brt ndr-brt merged commit cb286d3 into eclipse-edc:main Oct 20, 2023
3 checks passed
@ndr-brt ndr-brt deleted the bump-angular-15 branch October 20, 2023 06:35
farhin23 pushed a commit to FraunhoferISST/edc-dashboard that referenced this pull request Mar 5, 2024
* build: bump Angular to 15

* PR remark

* cleanup workflow file

* Add first e2e test

* PR remark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants