Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fatal error while resume PULL transfer from provider #4647

Conversation

AndrYurk
Copy link
Contributor

@AndrYurk AndrYurk commented Nov 26, 2024

What this PR changes/adds

Adds a SUSPENDED state to the list of allowed states to be consumer started.

Why it does that

When provider resume the transfer it initiate transitionStarted for the consumer from SUSPENDED state, that is currently not allowed, as a result consumer return an error for the provider and transfer move to TERMINATED state.

Further notes

To make possible create e2e test by provider commands, method awaitTransferToBeInState from TransferEndToEndTestBase need to be unified.

Linked Issue(s)

Closes #4591

@AndrYurk AndrYurk force-pushed the DOS-1413-Error-while-resume-PULL-transfer-process branch from 4b19572 to fc6c43f Compare November 26, 2024 16:41
@AndrYurk AndrYurk added the bug Something isn't working label Nov 26, 2024
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndr-brt ndr-brt merged commit 1d74c05 into eclipse-edc:main Nov 28, 2024
24 checks passed
@ndr-brt ndr-brt deleted the DOS-1413-Error-while-resume-PULL-transfer-process branch November 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error while resume PULL transfer process
2 participants