Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Termination of pull transfer process from consumer side not succe… #4637

Conversation

AndrYurk
Copy link
Contributor

…ss in real but stated as "TERMINATED"

What this PR changes/adds

Run termination process from data flow manager for provider when termination initiated by consumer

Why it does that

During termination PULL transfer process from consumer, system does not call method terminate() from DataFlowManager on provider side.
As a result process not terminated in real but transfer process had state "TERMINATED", and then it is not possible to initiate terminating process again not from consumer neither form provider side.

Further notes

N/A

Linked Issue(s)

#4592

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Nov 20, 2024

@AndrYurk do NOT submit surprise PRs. Our PR Etiquette clearly states to submit a discussion or an issue first.
Committers need a chance to look at the issue and triage it.

Also, your code does NOT come with any sort of testing. I recommend closing this, following proper procedure and then opening another PR that will pass muster.

Oh, and you need to sign the ECA.

@AndrYurk
Copy link
Contributor Author

@paullatzelsperger, thank you very much for the comment and clear explanation.
PR has been closed and will be recreated according to Pull Request Etiquette.

@AndrYurk AndrYurk deleted the DOS-1442-Termination-of-pull-transfer-process-from-consumer-side-not-success-in-real-but-stated-as-TERMINATED branch November 20, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants