fix: add capability to encode kid header in request to Oauth2 server
#4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
changed the title
kid header in request to Oauth2 server
...on/oauth2-spi/src/test/java/org/eclipse/edc/iam/oauth2/spi/Oauth2AssertionDecoratorTest.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
fix/oauth2_kid_header
branch
2 times, most recently
from
c94c50c
to
60db49b
Compare
jimmarino
reviewed
Nov 14, 2024
.../iam/oauth2/oauth2-core/src/main/java/org/eclipse/edc/iam/oauth2/Oauth2ServiceExtension.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
fix/oauth2_kid_header
branch
from
60db49b
to
a620e9d
Compare
jimmarino
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
As of today, Oauth2AssertionDecorator does not provide the capability to encode the optional kid header in the access token request to Oauth2 server.
Why it does that
We should be able to specify a kid: https://www.rfc-editor.org/rfc/rfc7515#page-11
Linked Issue(s)
Closes #4626
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.