docs: typed policy engine DR #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
wolf4ood,
jimmarino,
paullatzelsperger and
bscholtes1A
docs/developer/decision-records/2024-10-05-typed-policy-engine/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2024-10-05-typed-policy-engine/README.md
Outdated
Show resolved
Hide resolved
jimmarino
requested changes
Oct 4, 2024
| - it makes no sense to have a function/validator bound to all the scopes, scopes have well defined bound, they could | ||
| share context content (e.g. `Instant now` field could be one of them), but this should happen at the `PolicyContext` | ||
| hierarchy level. | ||
| - scope hierarchy won't be a thing anymore (e.g. `scope` and `scope.child`) |
There was a problem hiding this comment.
This is used. Let's discuss this
|
@jimmarino @paullatzelsperger I revisited the DR scope, now is more narrow and it will permit to keep scopes hierarchy. |
|
@jimmarino DR is ready to review |
wolf4ood
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds DR for typed policy engine refactor
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Part of #3511
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.