feat: enable defining supported VC types for trusted issuers #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
requested changes
Sep 5, 2024
.../main/java/org/eclipse/edc/iam/identitytrust/core/defaults/DefaultTrustedIssuerRegistry.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
feat/4453-trusted_issuers_supported_vc_type
branch
from
8a47864
to
1bd41e0
Compare
jimmarino
approved these changes
Sep 6, 2024
...redentials/src/main/java/org/eclipse/edc/iam/verifiablecredentials/rules/HasValidIssuer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/iam/verifiablecredentials/spi/validation/TrustedIssuerRegistry.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/iam/verifiablecredentials/spi/validation/TrustedIssuerRegistry.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
feat/4453-trusted_issuers_supported_vc_type
branch
from
1bd41e0
to
cc6bb85
Compare
bscholtes1A
force-pushed
the
feat/4453-trusted_issuers_supported_vc_type
branch
from
cc6bb85
to
408f402
Compare
wolf4ood
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
As of today the TrustedIssuerRegistry defines the list of trusted issuers ids. When validating the counter-party VCs, it is just checked that the issuer of each of these VC is contained in that list, which is quite limiting.
A typical use-case is that we want to be able to define the types of VCs that are supported for each trusted issuer.
Why it does that
VC validation module.
Linked Issue(s)
Closes #4453
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.