fix: consider terminated a non existing DataFlow #4420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add null checks on the
dataPlaneId
in theDataPlaneSignalingFlowController
Why it does that
Avoid exceptions: terminating a
DataFlow
that does not exist will returnsuccess
, because it can implicitly be considered terminatedFurther notes
suspend
method, but it work differently, it will return failure ifdataPlaneId
is null, because a non existing data flow cannot be suspended and that needs to be notified.Linked Issue(s)
Closes #4418
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.