Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider terminated a non existing DataFlow #4420

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 21, 2024

What this PR changes/adds

Add null checks on the dataPlaneId in the DataPlaneSignalingFlowController

Why it does that

Avoid exceptions: terminating a DataFlow that does not exist will return success, because it can implicitly be considered terminated

Further notes

  • added the check also on the suspend method, but it work differently, it will return failure if dataPlaneId is null, because a non existing data flow cannot be suspended and that needs to be notified.

Linked Issue(s)

Closes #4418

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Aug 21, 2024
@ndr-brt ndr-brt requested a review from wolf4ood August 21, 2024 07:49
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (7f20ba5) to head (b6ea76d).
Report is 389 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4420      +/-   ##
==========================================
+ Coverage   71.74%   74.97%   +3.22%     
==========================================
  Files         919     1075     +156     
  Lines       18457    21473    +3016     
  Branches     1037     1172     +135     
==========================================
+ Hits        13242    16099    +2857     
- Misses       4756     4854      +98     
- Partials      459      520      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt changed the title fix: consider terminated a DataFlow that cannot be terminated because it does not exist fix: consider terminated a non existing DataFlow Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when terminating a data flow that has not been started
4 participants