refactor: extract data-plane-iam module from data-plane-core #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
ndr-brt
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4408 +/- ##
==========================================
+ Coverage 71.74% 74.96% +3.22%
==========================================
Files 919 1075 +156
Lines 18457 21467 +3010
Branches 1037 1171 +134
==========================================
+ Hits 13242 16093 +2851
- Misses 4756 4854 +98
- Partials 459 520 +61 ☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
4 times, most recently
from
8c1fc5d
to
fb7f8b3
Compare
|
This pull request is stale because it has been open for 7 days with no activity. |
paullatzelsperger
approved these changes
Aug 20, 2024
.../java/org/eclipse/edc/connector/dataplane/iam/service/DataPlaneAuthorizationServiceImpl.java
Outdated
Show resolved
Hide resolved
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
2 times, most recently
from
94b9f0c
to
d59f606
Compare
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
from
091733b
to
2f442a4
Compare
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
from
2f442a4
to
9692824
Compare
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
from
3aa183a
to
d5e80e3
Compare
ndr-brt
force-pushed
the
4407-extract-data-plane-iam
branch
from
d5e80e3
to
a9cb8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Extract
data-plane-iammodule fromdata-plane-coreWhy it does that
modularity: it will permit data-plane runtime to run "only PUSH transfers": without requiring mandatory PULL-related settings.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4407
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.