feat(api): add additional scopes to the CatalogRequest #4348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds an optional list
additionalScopes
to theCatalogRequest
(CatalogApi DTO) and theCatalogRequestMessage
(DSP message).These additional scopes can be used by certain implementations of the
IdentityService
to enrich the generated token.For example, in DCP we can use this to attach additional scope strings to the
access_token
, effectively giving permissions to request more credentials from the CredentialService.Why it does that
being able to request additional VerifiableCredentials from the wallet
Further notes
/v3.1alpha
context url pathinstanceof
check in theDspHttpRemoteMessageDispatcherImpl
might not be the most elegant solution, but it is the least impactful, and considering that we don't really foresee additionalScopes for any other DSP message, it seemed good enough.Linked Issue(s)
Closes #4322
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.