feat(api, spi, storage): policy profile implementation #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschaisele-zf
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4332 +/- ##
==========================================
+ Coverage 71.74% 74.91% +3.17%
==========================================
Files 919 1066 +147
Lines 18457 21389 +2932
Branches 1037 1172 +135
==========================================
+ Hits 13242 16024 +2782
- Misses 4756 4839 +83
- Partials 459 526 +67 ☔ View full report in Codecov by Sentry. |
|
fyi @ndr-brt |
saschaisele-zf
force-pushed
the
feat/policy_profile
branch
from
436f908
to
ed1779d
Compare
|
@saschaisele-zf I am currently working on adding the I assume i'll have this done shortly. Could you wait a little, and rebase on that once i'm finished? |
paullatzelsperger
added
enhancement
|
Can do that. |
|
#4343 is merged, good to rebase |
saschaisele-zf
force-pushed
the
feat/policy_profile
branch
from
f32e8ac
to
4b70956
Compare
ndr-brt
reviewed
Jul 9, 2024
...a/org/eclipse/edc/connector/controlplane/api/management/policy/v3/PolicyDefinitionApiV3.java
Outdated
Show resolved
Hide resolved
ndr-brt
requested changes
Jul 9, 2024
...dator-lib/src/main/java/org/eclipse/edc/validator/jsonobject/validators/OptionalIdArray.java
Outdated
Show resolved
Hide resolved
...dator-lib/src/main/java/org/eclipse/edc/validator/jsonobject/validators/OptionalIdArray.java
Outdated
Show resolved
Hide resolved
...dator-lib/src/main/java/org/eclipse/edc/validator/jsonobject/validators/OptionalIdArray.java
Outdated
Show resolved
Hide resolved
...alidator-lib/src/test/java/org/eclipse/edc/validator/jsonobject/JsonObjectValidatorTest.java
Outdated
Show resolved
Hide resolved
...n-ld-spi/src/main/java/org/eclipse/edc/jsonld/spi/transformer/AbstractJsonLdTransformer.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Jul 10, 2024
...r/controlplane/api/management/policy/v31alpha/PolicyDefinitionApiV31AlphaControllerTest.java
Outdated
Show resolved
Hide resolved
added profile to the validation added profile to the policy model added profile to the sql storage Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
saschaisele-zf
force-pushed
the
feat/policy_profile
branch
from
e06232c
to
244d0e3
Compare
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
ndr-brt
approved these changes
Jul 10, 2024
ndr-brt
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds the odrl:profile attribute to the policy model.
This includes the necessary changes to the api, validation, transformation, spi and storage.
BREAKING CHANGE: a new
profiles JSONcolumn has been added to theedc_policydefinitionstableWhy it does that
The change is necessary to conform to ODRL v2.2
Further notes
For better validation, a new array validator named 'MandatoryIdArray' was added that ensures the array is a list of 'id' values.
To accomodate the transformation, the 'AbstractJsonLdTransformer' was extended with the 'transformIdStringArray' method.
Linked Issue(s)
Closes #3691
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.