Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add decision record about optional params in CatalogRequest #4325

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

adds a decision record about adding a new, optional parameters field to the CatalogRequest body

Why it does that

documentation

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4322

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the documentation Improvements or additions to documentation label Jul 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.24%. Comparing base (7f20ba5) to head (f49d066).
Report is 341 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4325      +/-   ##
==========================================
+ Coverage   71.74%   75.24%   +3.50%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21139    +2682     
  Branches     1037     1183     +146     
==========================================
+ Hits        13242    15907    +2665     
+ Misses       4756     4714      -42     
- Partials      459      518      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger force-pushed the docs/decision-record_about_additional_param_in_catalogrequest branch from 98ae4b9 to f49d066 Compare July 5, 2024 05:59
@paullatzelsperger paullatzelsperger merged commit 7ecc86e into eclipse-edc:main Jul 7, 2024
22 checks passed
@paullatzelsperger paullatzelsperger deleted the docs/decision-record_about_additional_param_in_catalogrequest branch July 7, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management API: add optional "scopes" parameter
5 participants