Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make pub/priv aliases mandatory at startup #4304

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 26, 2024

What this PR changes/adds

Read priv/pub aliases from configuration at startup, ensuring that the runtime won't start if they're not provided.

Why it does that

Avoid lazy failures.

Further notes

  • Fixed some test tags (that will distribute tests in different ci jobs in a better way)
  • in the transfer e2e created the noPolicyConstraints just once.
  • EDIT: I took the opportunity to get rid of the infamous backend-service, relying only on instances of mockserver instead

Linked Issue(s)

Closes #3994

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Jun 26, 2024
@ndr-brt ndr-brt requested a review from wolf4ood June 26, 2024 08:34
@ndr-brt ndr-brt marked this pull request as ready for review June 26, 2024 08:34
@ndr-brt ndr-brt changed the title feat: make pub/priv alias mandatory at startup feat: make pub/priv aliases mandatory at startup Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.18%. Comparing base (7f20ba5) to head (2b88a6f).
Report is 327 commits behind head on main.

Files Patch % Lines
...ramework/DataPlaneDefaultIamServicesExtension.java 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4304      +/-   ##
==========================================
+ Coverage   71.74%   75.18%   +3.43%     
==========================================
  Files         919     1052     +133     
  Lines       18457    21114    +2657     
  Branches     1037     1180     +143     
==========================================
+ Hits        13242    15874    +2632     
+ Misses       4756     4725      -31     
- Partials      459      515      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino
Copy link
Contributor

  • EDIT: I took the opportunity to get rid of the infamous backend-service, relying only on instances of mockserver instead

😄 🪓

@ndr-brt ndr-brt merged commit cb57f7f into eclipse-edc:main Jun 26, 2024
23 of 24 checks passed
@ndr-brt ndr-brt deleted the 3994-mandatory-keys branch June 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: public/private key aliases should be mandatory at boot time
3 participants