Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: openapi version link #4286

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 19, 2024

What this PR changes/adds

Add resources/openapi/*.version files, that contain each the path to the version.json that will be used by the publish-openapi-ui workflow to set the correct version in the published specs.

Why it does that

api versioning

Further notes

  • an alternative would be to put all the version.json in the resources/openapi folder and have a build taks in the modules that require it as resource to take care of copying it in the build resource folder, but the current implementation was easier so for the moment it will be preferable

Linked Issue(s)

Part of #4182

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added documentation Improvements or additions to documentation api Feature related to the (REST) api build Anything related to the CI/CD Pipeline on Github Actions labels Jun 19, 2024
@ndr-brt ndr-brt merged commit 963f2d9 into eclipse-edc:main Jun 20, 2024
18 checks passed
@ndr-brt ndr-brt deleted the build-openapi-version branch June 20, 2024 06:16
ndr-brt added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api build Anything related to the CI/CD Pipeline on Github Actions documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants