-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Delegated Authentication Service #4270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
New feature or request
api
Feature related to the (REST) api
labels
Jun 13, 2024
...legated/src/main/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationService.java
Fixed
Show fixed
Hide fixed
Test Results 856 files + 3 856 suites +3 20m 4s ⏱️ -18s Results for commit d17abb5. ± Comparison against base commit bacdf5a. This pull request removes 158 and adds 182 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
FYI @lgblaumeiser. can't request your review, but feel free to take a look. |
paullatzelsperger
force-pushed
the
feat/4261_delegating_auth_service
branch
from
June 14, 2024 07:16
1daa3e4
to
59154db
Compare
wolf4ood
approved these changes
Jun 14, 2024
ndr-brt
reviewed
Jun 17, 2024
...token-core/src/test/java/org/eclipse/edc/jwt/rules/ExpirationIssuedAtValidationRuleTest.java
Outdated
Show resolved
Hide resolved
core/common/token-core/src/test/java/org/eclipse/edc/jwt/rules/NotBeforeValidationRuleTest.java
Outdated
Show resolved
Hide resolved
...legated/src/main/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationService.java
Outdated
Show resolved
Hide resolved
...legated/src/main/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationService.java
Show resolved
Hide resolved
...h/auth-delegated/src/main/java/org/eclipse/edc/api/auth/delegated/JwksPublicKeyResolver.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feat/4261_delegating_auth_service
branch
from
June 17, 2024 07:07
2050258
to
8f86c3b
Compare
ndr-brt
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements the
DelegatedAuthenticationService
that takes a bearer token and validates it against a public key resolved from a JWKS url.Why it does that
Delegating auth and related tasks (rotation, revocation,...) away from the connector
Further notes
JwksPublicKeyResolver
NotBeforeValidationRule
andExpirationIssuedAtValidationRule
have received an optionalallowNull
argument, becausenbf
andexp
are not mandatory claims in general (they might be in certain OAuth2 flows)TokenBasedAuthenticationService
is only registered, if no other service is registered for the"management-api"
context. That way, it yields the way to other implementations.Linked Issue(s)
Closes #4261
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.