Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQL implementation of the EDR index store #4025

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 19, 2024

What this PR changes/adds

SQL implementation of the EDR index store

Why it does that

Persistent Postgres/SQL variant of the EDR index store.

Linked Issue(s)

Closes #3972

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Mar 19, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Mar 19, 2024
@wolf4ood wolf4ood force-pushed the feat/3972_edr_cache_sql_store branch 3 times, most recently from edc4056 to 9be01fd Compare March 20, 2024 07:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.82%. Comparing base (7f20ba5) to head (a5b8c44).
Report is 156 commits behind head on main.

Files Patch % Lines
...re/sql/edr/SqlEndpointDataReferenceEntryIndex.java 88.40% 7 Missing and 1 partial ⚠️
...r/SqlEndpointDataReferenceEntryIndexExtension.java 85.71% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
+ Coverage   71.74%   73.82%   +2.08%     
==========================================
  Files         919      991      +72     
  Lines       18457    20085    +1628     
  Branches     1037     1123      +86     
==========================================
+ Hits        13242    14828    +1586     
- Misses       4756     4780      +24     
- Partials      459      477      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood marked this pull request as ready for review March 20, 2024 08:05
@wolf4ood wolf4ood force-pushed the feat/3972_edr_cache_sql_store branch from 9be01fd to a5b8c44 Compare March 20, 2024 09:26
@wolf4ood wolf4ood merged commit 7f9b059 into eclipse-edc:main Mar 21, 2024
16 checks passed
@wolf4ood wolf4ood deleted the feat/3972_edr_cache_sql_store branch March 21, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: SQL EDR cache
3 participants