Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename ContractOfferService to ContractOfferResolver #2113

Merged
merged 1 commit into from
Oct 24, 2022
Merged

chore: rename ContractOfferService to ContractOfferResolver #2113

merged 1 commit into from
Oct 24, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 19, 2022

What this PR changes/adds

Rename one of the ContractOfferServices to ContractOfferResolver

Why it does that

To avoid duplicated class names and let the class be more self-explainatory

Further notes

Linked Issue(s)

Closes #1248

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Oct 19, 2022
@ndr-brt ndr-brt temporarily deployed to Azure-dev October 19, 2022 13:37 Inactive
paullatzelsperger
paullatzelsperger approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could capture these kinds of naming changes in a D-R? I.e. "internal services are not named '-service' anymore", etc.

@ndr-brt
Copy link
Member Author

ndr-brt commented Oct 24, 2022

@paullatzelsperger yes, this will come with #1887 for the moment I just wanted to close this issue quickly :)

@ndr-brt ndr-brt merged commit d683169 into eclipse-edc:main Oct 24, 2022
@ndr-brt ndr-brt deleted the feature/1248-rename-contract-offer-service branch October 24, 2022 06:40
@paullatzelsperger
Copy link
Member

@paullatzelsperger yes, this will come with #1887 for the moment I just wanted to close this issue quickly :)

That is perfectly fine:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronjaquensel ronjaquensel ronjaquensel approved these changes

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@juliapampus juliapampus Awaiting requested review from juliapampus

Assignees
No one assigned
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContractDefinitionService interface exists twice
3 participants
@ndr-brt @paullatzelsperger @ronjaquensel