refactor: default providers #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger and
jimmarino
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
- Coverage 62.93% 62.91% -0.03%
==========================================
Files 784 786 +2
Lines 16635 16599 -36
Branches 1081 1078 -3
==========================================
- Hits 10470 10443 -27
+ Misses 5714 5706 -8
+ Partials 451 450 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
paullatzelsperger
approved these changes
Sep 19, 2022
| */ | ||
| public class DefaultServicesExtension implements ServiceExtension { | ||
| public class DefaultCoreExtension implements ServiceExtension { |
There was a problem hiding this comment.
suggestion: how about naming these types of extensions Default...ervicesExtension, since they provide default core services...? Naming may get overly long at times though.
There was a problem hiding this comment.
@paullatzelsperger Actually that's a good advice, I renamed all these extensions in the *DefaultServicesExtension format and same for the name() method return value: * Default Services. Makes everything clearer.
bscholtes1A
approved these changes
Sep 19, 2022
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Cleanup default providers following the documentation guidelines
Why it does that
Project structure review
Further notes
DidStoreas it wasn't usedLinked Issue(s)
Closes #1812
Checklist
no-changelog)