Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: decision record about project structure review #1803

Merged
merged 2 commits into from
Aug 11, 2022
Merged

docs: decision record about project structure review #1803

merged 2 commits into from
Aug 11, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 9, 2022 •
edited
Loading

What this PR changes/adds

Add decision record about project structure review

Why it does that

To keep track of this decision

Further notes

Linked Issue(s)

Closes #1807

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Aug 9, 2022
paullatzelsperger
paullatzelsperger approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments, other than that -> good to go.

docs/developer/decision-records/2022-08-09-project-structure-review/README.md Outdated Show resolved Hide resolved
docs/developer/decision-records/2022-08-09-project-structure-review/README.md Outdated Show resolved Hide resolved
docs/developer/decision-records/2022-08-09-project-structure-review/README.md Outdated Show resolved Hide resolved
docs/developer/decision-records/2022-08-09-project-structure-review/README.md Outdated Show resolved Hide resolved
docs/developer/decision-records/2022-08-09-project-structure-review/README.md Outdated Show resolved Hide resolved
@paullatzelsperger paullatzelsperger mentioned this pull request Aug 10, 2022
Closed
2 tasks
@jimmarino
Copy link
Contributor

+1 from me

@mspiekermann
Copy link
Contributor

+1

@ndr-brt ndr-brt merged commit c2337fb into eclipse-edc:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@juliapampus juliapampus Awaiting requested review from juliapampus juliapampus is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Structure: create decision record
4 participants
@ndr-brt @jimmarino @mspiekermann @paullatzelsperger