Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete secrets #2

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Removes some obsolete repo secrets from the otterdog config.

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@github-actions

This comment has been minimized.

Copy link
Contributor

@netomi netomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked that these secrets are not used anymore by any workflow.

Signed-off-by: Thomas Neidhart <[email protected]>
@github-actions
Copy link

Diff for 0b01f70:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-edc[id=eclipse-edc]
  there have been 58 validation infos, enable verbose output with '-v' to to display them.

-   remove repo_secret[name="AZ_STORAGE_KEY", repository="Connector"] {
-     name                                                     = "AZ_STORAGE_KEY"
-   }

-   remove repo_secret[name="AZ_STORAGE_SAS", repository="Connector"] {
-     name                                                     = "AZ_STORAGE_SAS"
-   }

-   remove repo_secret[name="COSMOS_KEY", repository="Connector"] {
-     name                                                     = "COSMOS_KEY"
-   }

-   remove repo_secret[name="S3_ACCESS_KEY_ID", repository="Connector"] {
-     name                                                     = "S3_ACCESS_KEY_ID"
-   }

-   remove repo_secret[name="S3_SECRET_ACCESS_KEY", repository="Connector"] {
-     name                                                     = "S3_SECRET_ACCESS_KEY"
-   }

-   remove repo_secret[name="COSMOS_KEY", repository="Technology-Azure"] {
-     name                                                     = "COSMOS_KEY"
-   }
  
  Plan: 0 to add, 0 to change, 6 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-edc[id=eclipse-edc]

@netomi netomi merged commit 6c52aba into eclipse-edc:main Sep 12, 2023
1 check passed
@netomi
Copy link
Contributor

netomi commented Sep 12, 2023

secrets have been deleted.

@paullatzelsperger paullatzelsperger deleted the chore/cleanup_repo_secrets branch September 12, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants