Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Removed custom user cli arguments from configuration object #1873

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[core] Removed custom user cli arguments from configuration object #1873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ecal/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,6 @@ set(ecal_header_cmn
include/ecal/config/subscriber.h
include/ecal/config/time.h
include/ecal/config/transport_layer.h
include/ecal/config/user_arguments.h
include/ecal/types/logging.h
include/ecal/types/monitoring.h
include/ecal/ecal.h
Expand Down
2 changes: 0 additions & 2 deletions ecal/core/include/ecal/config/configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include <ecal/config/monitoring.h>
#include <ecal/config/registration.h>
#include <ecal/config/logging.h>
#include <ecal/config/user_arguments.h>
#include <ecal/config/publisher.h>
#include <ecal/config/subscriber.h>
#include <ecal/config/time.h>
Expand All @@ -55,7 +54,6 @@ namespace eCAL
Time::Configuration timesync;
Application::Configuration application;
Logging::Configuration logging;
Cli::Configuration command_line_arguments;

ECAL_API Configuration();

Expand Down
41 changes: 0 additions & 41 deletions ecal/core/include/ecal/config/user_arguments.h
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions ecal/core/src/ecal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,6 @@ namespace eCAL

// (post)initialize single components
const auto success = g_globals()->Initialize(components_);

if (config_.command_line_arguments.dump_config)
{
Process::DumpConfig();
}

return success;
}
Expand Down
Loading