Core (TCP Layer): Added bytes-alignment field in TCP Header to 8-byte-align the TCP user payload. #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-align the TCP user payload. This solves an issue with Capnproto. Capnproto requires the serialized data to be 8-bytes-aligned in memory. By already sending the payload 8-byte-aligned, this solves that issue.
rex-schilasky
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
So what I don't get here. It's 100% compatible with older senders / receivers, yet it doesn't work if you fill the memory with "/0".
So what does it actually append? If you know, you can manually fill the memory accordingly 😉
But also do not know if this is better or not.
Still hate this solution. And (latest for eCAL6) I vote for version numbers in the protocol, so ecal senders / receivers can negotiate a protocol version on all ecal layers (shm, udp, tcp, ...)
|
This PR was untested and should not have been merged. I wanted to merge it after @chengguizi tested it, as mentioned in #1017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue with Capnproto. Capnproto requires the serialized data to be 8-bytes-aligned in memory. By already sending the payload 8-byte-aligned, this solves that issue.
Fixes #1017