Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system tests workflow #2034

Merged
merged 1 commit into from
Sep 27, 2024
Merged

system tests workflow #2034

merged 1 commit into from
Sep 27, 2024

Conversation

alstanchev
Copy link
Contributor

@alstanchev alstanchev commented Sep 26, 2024 •
edited by thjaeckle
Loading

A system tests workflow.
Resolves: #2029

@alstanchev
system tests workflow
5df6ee7 
Signed-off-by: Aleksandar Stanchev <[email protected]>
@alstanchev
Copy link
Contributor Author

alstanchev commented Sep 26, 2024 •
edited
Loading

@thjaeckle it is posible that it may need fine tuning as i only ran it localy and haven't tested the publishing of the test results and logs.

thjaeckle
thjaeckle approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's merge and try it out :)

@thjaeckle thjaeckle added this to the 3.6.0 milestone Sep 27, 2024
@alstanchev alstanchev merged commit 6ba108d into eclipse-ditto:master Sep 27, 2024
3 checks passed
@thjaeckle
Copy link
Member

@alstanchev did you see?
I tried running the system-tests GitHub action - and it failed .. but the output seemed strange to me, because in "Setup JDK" step it already needed the Ditto pom.xml?!

@alstanchev
Copy link
Contributor Author

Yes it is strange to me too, but comparing it to the maven workflow where the checkout is first I suspect there is something underneath that expects the code to be present (maybe because of the maven caching) I made a change but saw some other things that maybe will be different compared to local run with act. So I went the documentation rabbit hole. Will commit the change later

@thjaeckle
Copy link
Member

Please go ahead an directly commit to master branch if that helps/speeds you up ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees

@alstanchev alstanchev

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Configure workflow for running system tests
2 participants
@alstanchev @thjaeckle