benchmark tool improvements #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use TestRun kubernetes resource, instead of k6, since it will be deprecated Add max retries on connection status fetching(CONNECTION_OPEN_MAX_RETRIES), after which the test aborts execution Add Service for mmock Use better naming for some env variables Add sample helm values.yaml for ditto Add --quiet false option for full logging when running k6 test inside kubernetes Remove AUTH_CONTEXT env var, value is equal to DITTO_PRE_AUTHENTICATED_HEADER_VALUE Signed-off-by: Vasil Vasilev <[email protected]>
…ight headers to ditto-helm-values.yaml Signed-off-by: Vasil Vasilev <[email protected]>
thjaeckle
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Looks good to me, thanks a lot @vvasilevbosch for improving this further 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix maxWait value to match the newest version of xk6-kafka
Use TestRun kubernetes resource, instead of k6, since it will be deprecated
Add max retries on connection status fetching(CONNECTION_OPEN_MAX_RETRIES), after which the test aborts execution
Add Service for mmock
Use better naming for some env variables
Add sample helm values.yaml for ditto
Add --quiet false option for full logging when running k6 test inside kubernetes
Remove AUTH_CONTEXT env var, value is equal to DITTO_PRE_AUTHENTICATED_HEADER_VALUE