removed X-Original-URI #1823
Merged
removed X-Original-URI #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kalinkostashki
commented
Nov 27, 2023
kalinkostashki
commented
- currently this header isn't handled by ditto
- if someone were to make a large request with many thingIds in a GET request the X-Original-URI will be passed as a Ditto Header in the protocol message causing a DittoHeadersTooLarge exception -> http error 431
kalinkostashki
force-pushed
the
bugfix/remove-x-original-uri
branch
from
3d3239f
to
5482144
Compare
- currently this header isn't handled by ditto - if someone were to make a large request with many thingIds in a GET request the X-Original-URI will be passed as a Ditto Header in the protocol message causing a DittoHeadersTooLarge exception -> http error 431 - reverted kindest to 1.28.0 as images for 1.28.3 are no longer in docker.io Signed-off-by: Kalin Kostashki <[email protected]>
kalinkostashki
force-pushed
the
bugfix/remove-x-original-uri
branch
from
5482144
to
f5dfbeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.