Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1806 Provide configurable search count metrics to be exposed via Prometheus #1807

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

thjaeckle
Copy link
Member

@thjaeckle thjaeckle commented Nov 15, 2023

  • make a common metric prefix configurable for all gathered Ditto custom metrics

  • Add and apply configuration for "searches" which should provide "count" metrics as Gauges in search

  • Include a "default" search/count, counting all things

  • Add documentation and example

  • provide configuration of those metrics via Helm chart values

Resolves: #1806

@thjaeckle thjaeckle added this to the 3.5.0 milestone Nov 15, 2023
@thjaeckle thjaeckle changed the title #1806 #1806 Provide configurable search count metrics to be exposed via Prometheus Nov 15, 2023
@thjaeckle thjaeckle self-assigned this Nov 15, 2023
@thjaeckle thjaeckle force-pushed the feature/1806-prometheus-exporters-for-search-counts branch 2 times, most recently from 4ca46ad to 74a2b29 Compare November 16, 2023 10:54
@thjaeckle thjaeckle marked this pull request as ready for review November 16, 2023 12:06
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki I would appreciate a review if you find the time :)

@thjaeckle thjaeckle force-pushed the feature/1806-prometheus-exporters-for-search-counts branch from 8c6a4c6 to f382ce5 Compare November 20, 2023 18:26
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the minor java doc for the namespace parameter
looks realy good 👍

* add new as singleton started Actor OperatorMetricsProviderActor responsible for gathering the metrics and reporting via DittoMetrics gauges
* provide configuration options for scrape-interval, namespaces to count and and RQL filter to apply, including optional tags to add to gauges
* provide example in configuration

Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle force-pushed the feature/1806-prometheus-exporters-for-search-counts branch from 76d50f5 to 459376e Compare November 30, 2023 08:33
@thjaeckle thjaeckle merged commit 9d5ec89 into master Nov 30, 2023
10 checks passed
@thjaeckle thjaeckle deleted the feature/1806-prometheus-exporters-for-search-counts branch November 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Provide configurable Prometheus metrics exporters, counting defined search queries
2 participants