-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1806 Provide configurable search count metrics to be exposed via Prometheus #1807
Merged
thjaeckle
merged 6 commits into
master
from
feature/1806-prometheus-exporters-for-search-counts
Nov 30, 2023
Merged
#1806 Provide configurable search count metrics to be exposed via Prometheus #1807
thjaeckle
merged 6 commits into
master
from
feature/1806-prometheus-exporters-for-search-counts
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thjaeckle
changed the title
#1806
#1806 Provide configurable search count metrics to be exposed via Prometheus
Nov 15, 2023
thjaeckle
force-pushed
the
feature/1806-prometheus-exporters-for-search-counts
branch
2 times, most recently
from
November 16, 2023 10:54
4ca46ad
to
74a2b29
Compare
@alstanchev @kalinkostashki I would appreciate a review if you find the time :) |
alstanchev
reviewed
Nov 20, 2023
documentation/src/main/resources/pages/ditto/installation-operating.md
Outdated
Show resolved
Hide resolved
thjaeckle
force-pushed
the
feature/1806-prometheus-exporters-for-search-counts
branch
from
November 20, 2023 18:26
8c6a4c6
to
f382ce5
Compare
alstanchev
reviewed
Nov 30, 2023
...earch/api/src/main/java/org/eclipse/ditto/thingsearch/api/commands/sudo/SudoCountThings.java
Show resolved
Hide resolved
alstanchev
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then the minor java doc for the namespace parameter
looks realy good 👍
… custom metrics Signed-off-by: Thomas Jäckle <[email protected]>
* add new as singleton started Actor OperatorMetricsProviderActor responsible for gathering the metrics and reporting via DittoMetrics gauges * provide configuration options for scrape-interval, namespaces to count and and RQL filter to apply, including optional tags to add to gauges * provide example in configuration Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
thjaeckle
force-pushed
the
feature/1806-prometheus-exporters-for-search-counts
branch
from
November 30, 2023 08:33
76d50f5
to
459376e
Compare
thjaeckle
deleted the
feature/1806-prometheus-exporters-for-search-counts
branch
November 30, 2023 12:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make a common metric prefix configurable for all gathered Ditto custom metrics
Add and apply configuration for "searches" which should provide "count" metrics as Gauges in search
Include a "default" search/count, counting all things
Add documentation and example
provide configuration of those metrics via Helm chart values
Resolves: #1806