Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR migrates Ditto to Apache Pekko #1730

Merged
merged 58 commits into from
Sep 18, 2023

Conversation

alstanchev
Copy link
Contributor

@alstanchev alstanchev commented Aug 28, 2023

Since the change of akka's license to "Business Source License (BSL) v1.1" this PR:

  1. Migrates all the code to use Apache Pekko framework (fork from Akka 2.6.21)
  2. Adapts the documentation, third party notices
  3. And all necessary changes.

Resolves: #1477

thjaeckle and others added 30 commits March 13, 2023 15:38
…rces controlled via UI

* added radiobutton groups so that "Authorize" modal clearly shows/states which authentication to use where
* reduced to a single "Authorize" button in modal
* simplified environment a bit

Signed-off-by: Thomas Jaeckle <[email protected]>
…ed on "main / devops" auth

Signed-off-by: Thomas Jaeckle <[email protected]>
Signed-off-by: Thomas Jaeckle <[email protected]>
* UI - New Operations tab
* added new tab
* changed way to control right auth user
* extended api to allow devops path
* utils to add table row now returns row
* crud editor returns explicit cancel action
* crud editor now with option without delete or create

Signed-off-by: thfries <[email protected]>

* UI - Operations Tab: new logger view

Signed-off-by: thfries <[email protected]>

* UI - operations tab - refresh not scrolling

* UI - change header info on new files

Signed-off-by: thfries <[email protected]>

* UI - Operations tab - make tabs optional
- fixed auth header mixing from wrong environment
- operations tab not getting right auth header

Signed-off-by: thfries <[email protected]>

* UI - added option to define new logger for each service in Operations / Logging functionality

Signed-off-by: Thomas Jäckle <[email protected]>

* UI - operations tab
- remove spellcheck from input
- split loggerView into smaller functions

Signed-off-by: thfries <[email protected]>

---------

Signed-off-by: thfries <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Co-authored-by: Thomas Jäckle <[email protected]>
* fallback to display connection "id" if no "name" is present

Signed-off-by: Thomas Jäckle <[email protected]>
…t in a merge patch using a regular expression

Signed-off-by: Thomas Jäckle <[email protected]>
…hes including a regex: in that case, unrestricted WRITE access on the contained JSON object is required

Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
…rActor#messageDiscarded

* to not use `responseDispatchedMonitor`, but getMonitorsForOutboundSignal() with using `responseMappedMonitor` instead for responses

Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Signed-off-by: Stanchev Aleksandar <[email protected]>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One first finding when roughly scrolling over the changes.
Will have a closer look soon.

Great effort @alstanchev 👍

bom/pom.xml Outdated Show resolved Hide resolved
@thjaeckle thjaeckle added this to the 3.4.0 milestone Aug 28, 2023
@alstanchev alstanchev force-pushed the feature/pekko-migration branch 2 times, most recently from 8258e29 to 34e35f3 Compare August 31, 2023 07:19
@alstanchev alstanchev force-pushed the feature/pekko-migration branch 2 times, most recently from 5d3c232 to 0a1d2b2 Compare August 31, 2023 08:26
* -Dpekko-contrib-mongodb-persistence-connection-remember-journal.overrides.metadata-index=akka_persistence_metadata_pid
```

And also a full cluster recreate is required, rolling update is not supported as there are changes in the management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alstanchev do the changes in management URLs require adjusting anything e.g. in the Helm chart?

Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alstanchev I reviewed by also starting locally and (manually) testing if data would still be there with Pekko - seems good as far as I can tell 👍

I had just one remark about the migration guide.

Signed-off-by: Aleksandar Stanchev <[email protected]>
@alstanchev
Copy link
Contributor Author

alstanchev commented Sep 18, 2023

@thjaeckle i have tested this with the helm chart and it is working. From my point of view it is ready for merge.

Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FMPOV also good to merge 👍

@alstanchev alstanchev merged commit 3c4f89d into eclipse-ditto:master Sep 18, 2023
2 checks passed
thjaeckle added a commit that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Migrate Ditto to use Apache Pekko instead of Akka after Akka's change to BSL license
4 participants